[cxx-interop] Make libstdc++ header and modulemap arch-independent #66855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
I think that this might require an associated change in apple/swift-installer-scripts: https://github.com/apple/swift-installer-scripts/blob/main/platforms/Windows/sdk.wxs#L418-L426 |
compnerd
previously requested changes
Jun 22, 2023
|
@swift-ci please build toolchain Windows platform |
|
Thanks @compnerd for pointing this out. |
egorzhdan
force-pushed
the
egorzhdan/libstdcxx-arch-independent
branch
from
0fb607e to
9b252ee
Compare
|
@swift-ci please smoke test |
|
@compnerd I put up a patch to update the Windows scripts (swiftlang/swift-installer-scripts#213) to accommodate for #66765. |
|
Ah, right, because this is for libstdc++ only! |
compnerd
approved these changes
Jun 22, 2023
egorzhdan
force-pushed
the
egorzhdan/libstdcxx-arch-independent
branch
from
9b252ee to
67eaebb
Compare
|
@swift-ci please smoke test |
This moves `libstdcxx.modulemap` and `libstdcxx.h` from `*.xctoolchain/usr/lib/swift/macosx/arm64e` to `*.xctoolchain/usr/lib/swift/macosx` to simplify distribution. rdar://110788977
egorzhdan
force-pushed
the
egorzhdan/libstdcxx-arch-independent
branch
from
67eaebb to
3e28a7c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
libstdcxx.modulemapandlibstdcxx.hfrom*.xctoolchain/usr/lib/swift/macosx/arm64eto*.xctoolchain/usr/lib/swift/macosxto simplify distribution.rdar://110788977